Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing updates #747

Merged
merged 2 commits into from
May 23, 2018
Merged

Hashing updates #747

merged 2 commits into from
May 23, 2018

Conversation

thomasvl
Copy link
Collaborator

No description provided.

thomasvl added 2 commits May 23, 2018 11:50
This way we only mix the fieldNumber once for these fields instead
of once per entry. The extra data into the hash doesn't really
buy us anything, and just slows down hash performance.
Conditional conformance on the containers now make them Hashable if they value
type is hashable. Use this instead of manually doing the hashing of the values
in the containers to get any standard library improvements.

https://swift.org/blog/conditional-conformance/ documents this as Swift 4.1,
but there seem to have been issues, as it fails until Swift 4.2.
@thomasvl thomasvl requested review from allevato and tbkka May 23, 2018 16:12
Copy link
Collaborator

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! \o/

@thomasvl thomasvl merged commit f997206 into apple:master May 23, 2018
@thomasvl thomasvl deleted the hashing_updates branch May 23, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants